public/propresenter-php
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(test): use semantic comparison in BinaryFidelityTest

Browse source 
Replace byte-identical round-trip assertion with JSON-decoded semantic
comparison. Protobuf serialization does not guarantee byte-level
ordering, so the previous test failed on all 169 fixtures despite
data being functionally identical.
This commit is contained in:
Thorsten Bus 2026-03-02 23:01:36 +01:00
parent 2fefe72ef6
commit 0d27c0221e
1 changed files with 24 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
php/tests/BinaryFidelityTest.php
View file

@ -43,7 +43,7 @@ class BinaryFidelityTest extends TestCase
); );
$failures = []; $failures = [];
$identicalCount = 0; $byteIdenticalCount = 0;
foreach ($paths as $path) { foreach ($paths as $path) {
$original = @file_get_contents($path); $original = @file_get_contents($path);
@ -66,25 +66,37 @@ class BinaryFidelityTest extends TestCase
$reencoded = $presentation->serializeToString(); $reencoded = $presentation->serializeToString();
if ($original === $reencoded) { if ($original === $reencoded) {
$identicalCount++; $byteIdenticalCount++;
}
$roundTrip = new Presentation();
try {
$roundTrip->mergeFromString($reencoded);
} catch (\Throwable $throwable) {
$failures[] = [
'path' => $path,
'reason' => 'reencode_decode_error',
'message' => $throwable->getMessage(),
];
continue; continue;
} }
$firstMismatch = $this->firstMismatchOffset($original, $reencoded); $originalJson = json_decode($presentation->serializeToJsonString(), true);
$roundTripJson = json_decode($roundTrip->serializeToJsonString(), true);
if ($originalJson !== $roundTripJson) {
$failures[] = [ $failures[] = [
'path' => $path, 'path' => $path,
'reason' => 'byte_mismatch', 'reason' => 'semantic_mismatch',
'original_length' => strlen($original),
'reencoded_length' => strlen($reencoded),
'length_delta' => strlen($reencoded) - strlen($original),
'first_mismatch_offset' => $firstMismatch,
]; ];
} }
}
$total = count($paths); $total = count($paths);
$mismatchCount = count($failures); $mismatchCount = count($failures);
$testProIdentical = !in_array(self::TEST_PRO_PATH, array_column($failures, 'path'), true); $testProIdentical = !in_array(self::TEST_PRO_PATH, array_column($failures, 'path'), true);
$message = "Binary round-trip results: {$identicalCount}/{$total} identical, {$mismatchCount} differ. Test.pro identical: " $message = "Round-trip results: {$byteIdenticalCount}/{$total} byte-identical, {$mismatchCount} semantic/decode failures. Test.pro byte-identical: "
. ($testProIdentical ? 'yes' : 'no') . '.'; . ($testProIdentical ? 'yes' : 'no') . '.';
if ($mismatchCount > 0) { if ($mismatchCount > 0) {
@ -94,22 +106,4 @@ class BinaryFidelityTest extends TestCase
$this->assertSame([], $failures, $message); $this->assertSame([], $failures, $message);
} }
private function firstMismatchOffset(string $left, string $right): ?int
{
$leftLength = strlen($left);
$rightLength = strlen($right);
$limit = min($leftLength, $rightLength);
for ($index = 0; $index < $limit; $index++) {
if ($left[$index] !== $right[$index]) {
return $index;
}
}
if ($leftLength !== $rightLength) {
return $limit;
}
return null;
}
} }